Chaosforge Forum

DoomRL => Bug Reports => Topic started by: Edgie! on February 29, 2012, 23:23

Title: [Fixed][0.9.9.6g] Crash at end (FIXED IN REPO)
Post by: Edgie! on February 29, 2012, 23:23
Hey there.  Had a crash happen to me at the end of a pacifism run.  After entering Dis, I used the bomb, hit the lever and started charging towards the end of the stage.  Bomb went off, saw explosions, and then crash.  I've played through the game before and won, though never using the pacifism challenge and never with a nuke. 

I'm using the normal windows graphical client on Vista Home Premium with SP1, Intel Core2 Duo, and a gig of ram.

thelaptop: I have merged all the crashes of 0.9.9.6 at the conclusion of the game.  The bug is noted and is fixed in the repository.  The workaround for the released version is to not equip any melee weapons on AoMr, AoSh or AoPc runs and end the game.
Title: Re: [0.9.9.6g] Crash at end
Post by: skarczew on March 01, 2012, 04:51
I'm using the normal windows graphical client on Vista Home Premium with SP1, Intel Core2 Duo, and a gig of ram.
Just general hint: get SP2 for Vista, it may help the system.
Title: Re: [0.9.9.6g] Crash at end
Post by: Edgie! on March 01, 2012, 06:54
That's good advice actually; guess it's been a while since my last update. 

Thanks.
Title: Re: [0.9.9.6g] Crash at end
Post by: Zecks on March 01, 2012, 08:04
I remember pacifism end nuke always crashing on the 0995 G beta. I sure hope it's not the case here too.
Title: Crash after killing Mastermind
Post by: spacedust on March 01, 2012, 11:03
I finally managed to kill the Mastermind on AoSg, and DoomRL crashed upon its death. Lol!

Edit: I loaded up the savegame, and it restarted me on Dis, and I killed the Mastermind again and it crashed again! Seems like the same message. I've attached the second error.log under the first entry, along with a copy of the save. Maybe someone can have a look at it?
----------------------------------------------------------------------
Timestamp   : 02/03/2012 07:01:00
Error level : FATAL EXCEPTION
Message     : Fatal exception encountered

An unhandled exception occurred at $004500CD :
ELuaException : Get(items.4.group) failed!
  $004500CD  TLUASYSTEM__GET,  line 397 of e:/Projects/fpcvalkyrie/src/vluasystem.pas
  $0045F13A  WEAPONGROUP,  line 1146 of src/dfhof.pas
  $0045E135  THOF__ADD,  line 1181 of src/dfhof.pas
  $00488B9A  TPLAYER__WRITEMEMORIAL,  line 1225 of src/dfplayer.pas
  $0041F02C  TDOOM__RUN,  line 376 of src/doombase.pas
  $00401B15  main,  line 71 of src/doomrl.pas

----------------------------------------------------------------------

----------------------------------------------------------------------
Timestamp   : 02/03/2012 07:06:43
Error level : FATAL EXCEPTION
Message     : Fatal exception encountered

An unhandled exception occurred at $004500CD :
ELuaException : Get(items.4.group) failed!
  $004500CD  TLUASYSTEM__GET,  line 397 of e:/Projects/fpcvalkyrie/src/vluasystem.pas
  $0045F13A  WEAPONGROUP,  line 1146 of src/dfhof.pas
  $0045E135  THOF__ADD,  line 1181 of src/dfhof.pas
  $00488B9A  TPLAYER__WRITEMEMORIAL,  line 1225 of src/dfplayer.pas
  $0041F02C  TDOOM__RUN,  line 376 of src/doombase.pas
  $00401B15  main,  line 71 of src/doomrl.pas

----------------------------------------------------------------------
Title: Re: Crash after killing Mastermind
Post by: spacedust on March 01, 2012, 11:12
Tried a third time, and it crashed with the same error. I am persistent if nothing lol.

Edit edit: Tried dying to see if that would make a difference. It didn't, but it produced a different error log.


----------------------------------------------------------------------
Timestamp   : 02/03/2012 07:19:15
Error level : ERROR
Message     : Lua hook OnAction caught ELuaException!

Call path     : beings[mastermind].OnAction
Call params   : ()
Error message : Get(items.4.group) failed!
----------------------------------------------------------------------

----------------------------------------------------------------------
Timestamp   : 02/03/2012 07:19:23
Error level : FATAL EXCEPTION
Message     : Fatal exception encountered

An unhandled exception occurred at $004624B9 :
ELuaException : LuaError: beings[mastermind].OnAction -- Get(items.4.group) failed!
  $004624B9  TDOOMLUA__ONERROR,  line 608 of src/doomlua.pas
  $00450DE7  TLUASYSTEM__PROTECTEDRUNHOOK,  line 539 of e:/Projects/fpcvalkyrie/src/vluasystem.pas
  $004A719B  TTHING__CALLHOOK,  line 141 of src/dfthing.pas
  $0049E4D4  TBEING__ACTION,  line 1170 of src/dfbeing.pas
  $0049E5EB  TBEING__CALL,  line 1188 of src/dfbeing.pas
  $0041EFDA  TDOOM__RUN,  line 369 of src/doombase.pas
  $00401B15  main,  line 71 of src/doomrl.pas

----------------------------------------------------------------------
Title: Re: Crash after killing Mastermind
Post by: Deathwind on March 01, 2012, 20:35
What operating system are you using?
Title: Re: Crash after killing Mastermind
Post by: spacedust on March 01, 2012, 21:11
XP SP3
Title: Re: [0.9.9.6g] Crash at end
Post by: Edgie! on March 02, 2012, 05:47
I brought another character down and repeated everything.  Same outcome.  I'd post the error log but only change was the time stamp.
Title: Re: [0.9.9.6g] Crash at end
Post by: MaiZure on March 03, 2012, 02:40
So far this version, I have beaten AoPc 3 times and all of them featured a wonderful crash at the end.

All games were the console version.
Title: [9.9.6lq] strange bug
Post by: bardysya on March 04, 2012, 19:29
Trying to beat pacifist gold badge stucked at strange bug, which happened after death. don't know, what is the hell this, but it stopped me in beating Pacifist gold!

Title: Re: [0.9.9.6g] Crash at end
Post by: thelaptop on March 04, 2012, 21:51
I've merged all the "crash at end" bug reports in the same place as per Game Hunter's suggestion.

Ed: According to Game Hunter, all the "crash at end" bugs have been resolved in the SVN.  We will release bug fixes when Kornel returns from his conference.

=)
Title: Re: [0.9.9.6g] Crash at end (FIXED IN REPO)
Post by: Game Hunter on March 05, 2012, 11:14
Since this particular kind of bug leads to quite unforgivable crashes, I'll be very specific as to what causes it.

Every time the something other than the player dies, the game registers that kill to an item, usually the one in the player's equipped weapon slot. In the case of melee weapons, since there are special rules regarding which weapon is used (involving Juggler), there's a function that figures out which equipment slot to check. Turns out that, if the melee weapon's firing hook doesn't work,  the function returns the torso slot instead! Thus, after the game is over and score stuff begins tallying kills by group, armors are also checked, and since they lack the group property, the game errors. This has been fixed to return a null value, which is appropriately ignored.

Practically-speaking, the error will eventually happen if you're on a challenge that won't let you use melee weapons (as is the case in AoMr, AoSg, and AoPc) and you're carrying a melee weapon around when something on the map died. The only time most players are going to trigger this in such a case is when you pick up the chainsaw in Chained Court and don't unequip it before something is killed: considering there's no reason not to unequip it in AoPc, this would happen quite frequently. To be extra-safe, don't leave the chainsaw (or any melee weapon) in your equipped or prepared slots, and there should be no problem with triggering the crash.