Chaosforge Forum

  • April 01, 2020, 15:01
  • Welcome, Guest
Please login or register.



Login with username, password and session length
Pages: [1]

Author Topic: First message being overwritten by second?  (Read 1724 times)

GinDiamond

  • First Sergeant
  • *
  • Offline Offline
  • Posts: 129
  • Warrant Officer-Mancubus, trying to get all Bronze
    • View Profile
    • GinDiamond Stuff
First message being overwritten by second?
« on: May 15, 2013, 19:23 »

I've noticed that sometimes, the level messages you get when you enter a level "You enter Phobos Level 6. You feel a breeze of morbid air!" will sometimes be overwritten by the next messages, and the first message won't show up in the message history.


Just a minor bug in 0.9.9.7.
Logged
Do not muddle in the affairs of Dragons, for thou art crunchy and taste good with ketchup.

Evilpotatoe

  • Backer
  • Major
  • *
  • *
  • Offline Offline
  • Posts: 316
  • Lost Soul corpse
    • View Profile
Re: First message being overwritten by second?
« Reply #1 on: May 16, 2013, 05:31 »

Noticed it too, and not sure it's only since 0.9.9.7
The very annoying part is that it overrides the level feelings. For that reason, it should be fixed. (Well, adding a command to remind feeling could be a good solution too, anw would prevent the need to look for it in hundreds of log lines)

Btw, if we don't know what makes it happen, it's quite harder :)
I just checked if it was produced by using the [l]ook command (I often look at some item, wanna check the feelings, and don't have them anymore.), but it wasn't enough.
Anyone knows how to reproduce ?
Logged
Badges - [26/26/26/22/9/2] - 42/43

Hamster

  • Elder
  • Sergeant
  • *
  • *
  • Offline Offline
  • Posts: 79
    • View Profile
Re: First message being overwritten by second?
« Reply #2 on: May 16, 2013, 07:21 »

adding a command to remind feeling
+1

Code: [Select]
Welcome to the Doom Roguelike... You enter Phobos, level 1. There's the smell
You see : Hamster (unhurt) | floor | [m]ore
As far as I know, [l]ooking just overwrites the last line of text.
Logged

GinDiamond

  • First Sergeant
  • *
  • Offline Offline
  • Posts: 129
  • Warrant Officer-Mancubus, trying to get all Bronze
    • View Profile
    • GinDiamond Stuff
Re: First message being overwritten by second?
« Reply #3 on: May 16, 2013, 17:58 »

If it overwrites the last line of the text, then our bugs match.
My thing was this:

Code: [Select]

You enter Phobos, level 6. You feel a breeze of morbid air..

to
Code: [Select]

You see : imp (unhurt) | floor | [f]ire

The last line of the text is the most recent text shown, so the bug must be that there isn't code that moves the first message (the one you see on level enter) to the line above when immediately faced with a new message. Should be a simple fix...?
Logged
Do not muddle in the affairs of Dragons, for thou art crunchy and taste good with ketchup.

Tormuse

  • Elder
  • General
  • *
  • *
  • Offline Offline
  • Posts: 1595
  • More Angelic than not
    • View Profile
Re: First message being overwritten by second?
« Reply #4 on: May 16, 2013, 19:36 »

This issue has been around forever.  It took me a while to get used to making sure I check the level feeling *before* I (l)ook at anything.  I miss important information all the time, otherwise.
Logged
Apostle Chaos Lt. General (0.9.9.7)
[26/26/26/26/18/9]
Check out my Youtube channel for videos of me playing DRL!  :)
https://www.youtube.com/channel/UCXOijubEijdnrOja0kxXTKQ/videos

ZicherCZ

  • Chaos Knight
  • Supporter of Chaos
  • Brigadier General
  • *
  • *
  • Offline Offline
  • Posts: 731
  • YADJHG - Yet Another Dead JupiterHellGuy
    • View Profile
Re: First message being overwritten by second?
« Reply #5 on: May 16, 2013, 23:19 »

You can still check the message log with Shift+P.
Also there's a config parameter (can't recall it's name now) that can be set up to hold more than default 100 lines in the message log. I would recommend to increase this, as a hundred lines can be quickly filled up, and then the level feeling is lost forever.
Logged
DoomRL 0.997: Cyberdemon Brigadier General - Games: 217, Wins: 2/5/3/6/0, Medals: 18, Specials: 64, Asm: 39, Badges: 19/17/16/5/1/Are you kidding?
Jupiter Hell: Inner Circle - first tech build reached and working

Hamster

  • Elder
  • Sergeant
  • *
  • *
  • Offline Offline
  • Posts: 79
    • View Profile
Re: First message being overwritten by second?
« Reply #6 on: May 17, 2013, 03:11 »

You can still check the message log with Shift+P.
Yep, but the previous line is overwritten there too.

Also there's a config parameter (can't recall it's name now) that can be set up to hold more than default 100 lines in the message log. I would recommend to increase this, as a hundred lines can be quickly filled up, and then the level feeling is lost forever.
Agree, personally I have 1000, that's enough for the most cases.
Logged

Tormuse

  • Elder
  • General
  • *
  • *
  • Offline Offline
  • Posts: 1595
  • More Angelic than not
    • View Profile
Re: First message being overwritten by second?
« Reply #7 on: May 17, 2013, 17:10 »

;
You can still check the message log with Shift+P.
Also there's a config parameter (can't recall it's name now) that can be set up to hold more than default 100 lines in the message log. I would recommend to increase this, as a hundred lines can be quickly filled up, and then the level feeling is lost forever.

I think you're misunderstanding the issue.  If you use the (l)ook command, it erases the last message from the message history.  It doesn't matter how high you set the number; it will immediately be gone forever.  It's a problem because, when you first start a level, the first thing you do is almost always going to be looking at things.  This means you almost always erase important level feeling information, probably before you even get a chance to read it.

Of course, this is only an issue for people like me who still use the console version, since I think the mouse-look doesn't erase stuff the same way the (l)ook command does.  :)
Logged
Apostle Chaos Lt. General (0.9.9.7)
[26/26/26/26/18/9]
Check out my Youtube channel for videos of me playing DRL!  :)
https://www.youtube.com/channel/UCXOijubEijdnrOja0kxXTKQ/videos

ZicherCZ

  • Chaos Knight
  • Supporter of Chaos
  • Brigadier General
  • *
  • *
  • Offline Offline
  • Posts: 731
  • YADJHG - Yet Another Dead JupiterHellGuy
    • View Profile
Re: First message being overwritten by second?
« Reply #8 on: May 18, 2013, 01:41 »

Ah. A misunderstanding on my part, definitely, and a real issue.
Logged
DoomRL 0.997: Cyberdemon Brigadier General - Games: 217, Wins: 2/5/3/6/0, Medals: 18, Specials: 64, Asm: 39, Badges: 19/17/16/5/1/Are you kidding?
Jupiter Hell: Inner Circle - first tech build reached and working

shark20061

  • Programmer
  • Elder Chaos Guard
  • Captain
  • *
  • *
  • Offline Offline
  • Posts: 266
    • View Profile
Re: First message being overwritten by second?
« Reply #9 on: May 20, 2013, 14:54 »

I'm going to work on trying to fix this issue.  I plan on adding both an extra line when doing any 'l'ook action as well as a repeat feeling option.  I'll post again when the fix is in repo.
Logged
Hell Knight Warrant Officer (0.9.9.4)  [26!/8/3/1/0]

Mancubus 2nd Lieutenant (0.9.9.6)  [22/12/3/0/0]
M:16 S:43 (126) A:17

shark20061

  • Programmer
  • Elder Chaos Guard
  • Captain
  • *
  • *
  • Offline Offline
  • Posts: 266
    • View Profile
Re: First message being overwritten by second?
« Reply #10 on: May 20, 2013, 22:52 »

...and done.  Both of the following changes are in the repo now.

Using 'l'ook will make a new line in the log, and no longer overwrite the last line.

Added a 'repeat level feeling' command, it is currently Shift-L (but it'll be customizable via keybindings).
Logged
Hell Knight Warrant Officer (0.9.9.4)  [26!/8/3/1/0]

Mancubus 2nd Lieutenant (0.9.9.6)  [22/12/3/0/0]
M:16 S:43 (126) A:17
Pages: [1]