Chaosforge Forum

  • July 06, 2020, 03:28
  • Welcome, Guest
Please login or register.



Login with username, password and session length
Pages: [1] 2 3  All

Author Topic: Pushing barrels paints a floor  (Read 6348 times)

singalen

  • Supporter
  • Second Lieutenant
  • *
  • *
  • Offline Offline
  • Posts: 172
  • Lost Soul
    • View Profile
Pushing barrels paints a floor
« on: August 30, 2013, 23:53 »

I pushed several barrels across a bridge, and one barrel started to paint tile it was on into a tile it's being moved onto.
Logged

thelaptop

  • Chaos Fanatic!
  • Grand Inquisitor
  • Apostle
  • *
  • *
  • Offline Offline
  • Posts: 2492
  • Grumpy Admin
    • View Profile
Re: Pushing barrels paints a floor
« Reply #1 on: August 31, 2013, 00:37 »

Known bug.  Not sure how we're going to fix it.  It has something to do with how the tiles are tracked internally.

Since this stomps on the Pascal side, we're probably going to wait for Kornel to decide how to fix it.

Thanks for the report though.
Logged
I compute, therefore I am.

Hell Baron 1st Lieutenant (0.9.9.7)
[20/12/8/0/0/0]

Malek Deneith

  • Grand Inquisitor Emeritus
  • Grand Inquisitor
  • Lieutenant General
  • *
  • *
  • Offline Offline
  • Posts: 1256
  • Lost Seraph
    • View Profile
Re: Pushing barrels paints a floor
« Reply #2 on: August 31, 2013, 01:23 »

I think the problem here is that barrels are considered tiles for some reason, so "moving" them actually swaps barrel tile with one in the direction you're going. The solution would be to change them to items, like teleportation portals are - seems to me like it'd work based on my limited understanding of game's inner workings.
Logged
Inquisition - saving your soul, one bolter shell at a time.
Spoiler: "Hackmaster Kills" (click to show/hide)

thelaptop

  • Chaos Fanatic!
  • Grand Inquisitor
  • Apostle
  • *
  • *
  • Offline Offline
  • Posts: 2492
  • Grumpy Admin
    • View Profile
Re: Pushing barrels paints a floor
« Reply #3 on: August 31, 2013, 01:44 »

It's actually the same problem as how moving the barrel across a bridge screws up the bridge in console mode.

I dunno... we can try a fix and see how it works out in 0.9.9.8 beta.
Logged
I compute, therefore I am.

Hell Baron 1st Lieutenant (0.9.9.7)
[20/12/8/0/0/0]

MaiZure

  • Marketing/PR Ops Lead
  • Greater Elder
  • Major General
  • *
  • *
  • Offline Offline
  • Posts: 827
  • Retired 1-Star General (.993)
    • View Profile
    • Project repository
Re: Pushing barrels paints a floor
« Reply #4 on: August 31, 2013, 04:17 »

This has to be the most re-reported bug in the history of DoomRL...

and I think I posted this same thing the last time it was reported!
Logged
Hell Knight 1st Lt. (.997)
[22/13/9/2/0]

Klear

  • Elder
  • Lieutenant General
  • *
  • *
  • Offline Offline
  • Posts: 1319
  • Twisted passages carry the smell of dapperness...
    • View Profile
Re: Pushing barrels paints a floor
« Reply #5 on: August 31, 2013, 05:11 »

Yep. I know I've reported this at least once.
Logged
Arch-Vile Mjr General [24/19/18/8/2] (0.9.9.7)

Quote from: thelaptop
Dude... we need to change your forum handle from "Klear" to "Klear Nukem".

Kornel Kisielewicz

  • God Hand
  • Apostle
  • *
  • *
  • Offline Offline
  • Posts: 4543
    • View Profile
    • http://chaosforge.org/
Re: Pushing barrels paints a floor
« Reply #6 on: August 31, 2013, 10:52 »

It should be marked as "will-not-fix" - this would require implementing another map layer especially for barrels, which in turn would require a lot of bug testing, which in turn would take a lot of time for a little gain. Time that could be better spent implementing new cool stuff.
Logged
at your service,
Kornel Kisielewicz

Malek Deneith

  • Grand Inquisitor Emeritus
  • Grand Inquisitor
  • Lieutenant General
  • *
  • *
  • Offline Offline
  • Posts: 1256
  • Lost Seraph
    • View Profile
Re: Pushing barrels paints a floor
« Reply #7 on: August 31, 2013, 11:14 »

I'm still having trouble understanding why barrels can't be handled the same way as teleporters. As far as I remember from my modding days teleporters are ITEMS placed on CELLS. They use OnEnter to do the teleportation - some additional tweaking might be needed to use that for moving them by triggering OnEnter but it doesn't look like it'd be "new layer just for barrels" level of complexity to add. And as items can already be destoroyed the "blow the barrel" part should be doable as well.

Am I missing something obvious here?
Logged
Inquisition - saving your soul, one bolter shell at a time.
Spoiler: "Hackmaster Kills" (click to show/hide)

yaflhdztioxo

  • Programmer
  • Elder Chaos Guard
  • Captain
  • *
  • *
  • Offline Offline
  • Posts: 298
  • Lost Sole
    • View Profile
Re: Pushing barrels paints a floor
« Reply #8 on: August 31, 2013, 11:23 »

You can't shoot or push items.  And it would be a lot of work, however you decided to tackle it, to fix the issue properly.

We could probably fix it improperly if nobody minds some egregious hacks :)
Logged

LuckyDee

  • Sound Wizard
  • Grand Inquisitor
  • General
  • *
  • *
  • Offline Offline
  • Posts: 1509
  • High Caliber Consecrator
    • View Profile
    • LuckyDeeIndustries
Re: Pushing barrels paints a floor
« Reply #9 on: September 02, 2013, 04:21 »

Being a total layman as to how this has been implemented, this just occurred to me: if the tiles are indeed swapped, as Malek suggests, can't you insert some kind of cross-reference mechanism? You number your tiles xxy with xx being floor type and y being barrel type (none/fuel/acid/BURNINATION) and compare tile numbers on swap. Source(xxy) becomes source(xx&destination(y)) and destination(xxy) becomes destination(xx&source(y)).

Ten to one someone's already tought of this, though...
Logged
[0.9.9.7G] Current: Hell Knight 1st Lieutenant [20/12/4/0/0/0]
High: Arch-Vile Lt. Colonel [25/21/12/2/1/0]

singalen

  • Supporter
  • Second Lieutenant
  • *
  • *
  • Offline Offline
  • Posts: 172
  • Lost Soul
    • View Profile
Re: Pushing barrels paints a floor
« Reply #10 on: September 02, 2013, 05:25 »

That's a quickfix I thought about. Make several types of barrels (barrel-on-floor, barrel-on-bridge) and change them on the go.
Logged

yaflhdztioxo

  • Programmer
  • Elder Chaos Guard
  • Captain
  • *
  • *
  • Offline Offline
  • Posts: 298
  • Lost Sole
    • View Profile
Re: Pushing barrels paints a floor
« Reply #11 on: September 02, 2013, 07:16 »

That would work but it would require defining a lot more cells--4x as many floor cells--to store the extra information.  A pseudo-layer (a sparse array) that tracked the barrels as they are generated and moved would be easier and is probably the least hacky quick fix available.
« Last Edit: September 02, 2013, 07:17 by yaflhdztioxo »
Logged

shark20061

  • Programmer
  • Elder Chaos Guard
  • Captain
  • *
  • *
  • Offline Offline
  • Posts: 266
    • View Profile
Re: Pushing barrels paints a floor
« Reply #12 on: September 03, 2013, 07:44 »

(never mind)
« Last Edit: September 03, 2013, 07:57 by shark20061 »
Logged
Hell Knight Warrant Officer (0.9.9.4)  [26!/8/3/1/0]

Mancubus 2nd Lieutenant (0.9.9.6)  [22/12/3/0/0]
M:16 S:43 (126) A:17

singalen

  • Supporter
  • Second Lieutenant
  • *
  • *
  • Offline Offline
  • Posts: 172
  • Lost Soul
    • View Profile
Re: Pushing barrels paints a floor
« Reply #13 on: September 03, 2013, 09:58 »

Aren't there only 2 floor types a barrel can be pushed onto?
I don't think a specific barrel layer is less hacky: it's a whole new data structure, it requires separate maintenance (both at run time and in coder's time), and it won't be exposed to Lua.
Logged

Mader Levap

  • Private FC
  • *
  • Offline Offline
  • Posts: 11
  • Lost Soul
    • View Profile
Re: Pushing barrels paints a floor
« Reply #14 on: September 03, 2013, 15:18 »

...and now that bad game design decision (barrels-as-floor-tiles) will haunt game forever. :(
Logged
Pages: [1] 2 3  All